[pve-devel] [PATCH common 1/1] CalendarEvent: use rust implementation

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jan 13 17:20:56 CET 2022


On 01.12.21 09:55, Dominik Csapak wrote:
> by replacing the parsing code and 'compute_next_event' by their
> PVE::RS::CalendarEvent equivalent
> 
> adapt the tests, since we do not have access to the internal structure
> (and even if we had, it would be different) and the error messages
> are different
> 
> the 'compute_next_event' and parsing tests still pass though
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/PVE/CalendarEvent.pm    | 251 +-----------------------------------
>  test/calendar_event_test.pl |  42 +++---
>  2 files changed, 23 insertions(+), 270 deletions(-)
> 
> diff --git a/src/PVE/CalendarEvent.pm b/src/PVE/CalendarEvent.pm
> index 56e9923..e2bf53a 100644
> --- a/src/PVE/CalendarEvent.pm
> +++ b/src/PVE/CalendarEvent.pm
> @@ -6,6 +6,7 @@ use Data::Dumper;
>  use Time::Local;
>  use PVE::JSONSchema;
>  use PVE::Tools qw(trim);
> +use PVE::RS::CalendarEvent;

this is actually not ideal as pve-common is also used in PMG and for some infra stuff, so
pve-rs isn't available there everywhere...

hacked around that for now by just dropping the d/control dependency for now, as I depend
on the correct pve-rs version in pve-manager directly anyway...






More information about the pve-devel mailing list