[pve-devel] applied-series: [PATCH proxmox-perl-rs/common] use calendar-events from rust

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jan 13 15:45:13 CET 2022


On 01.12.21 09:55, Dominik Csapak wrote:
> this series replaces the perl calendar event implementation with the
> one in rust, using proxmox-perl-rs
> 
> the perl interface to 'PVE::CalendarEvent' is the same, but we could
> use PVE::RS::CalendarEvent directly downstream (guest-common/manager)
> but since we need the api type anyway i left that out for now
> 
> with this, we now get all features from the rust implementation
> in perl now, most notably the date part of events which makes it
> possible to have e.g. backups less that once per week (e.g. on the
> first of the month)
> 
> this depends of course on my series to add 'UTC' to the events[0]
> 
> 0: https://lists.proxmox.com/pipermail/pbs-devel/2021-December/004413.html
> 
> proxmox-perl-rs:
> 
> Dominik Csapak (1):
>   pve-rs: add PVE::RS::CalendarEvent
> 
>  pve-rs/Makefile              |  1 +
>  pve-rs/src/calendar_event.rs | 20 ++++++++++++++++++++
>  pve-rs/src/lib.rs            |  1 +
>  3 files changed, 22 insertions(+)
>  create mode 100644 pve-rs/src/calendar_event.rs
> 
> pve-common:
> 
> Dominik Csapak (1):
>   CalendarEvent: use rust implementation
> 
>  src/PVE/CalendarEvent.pm    | 251 +-----------------------------------
>  test/calendar_event_test.pl |  42 +++---
>  2 files changed, 23 insertions(+), 270 deletions(-)
> 

Applied with a followup to actually add `proxmox-time` as dependency in Cargo.toml to
avoid the following compile error:

   Compiling pve-rs v0.5.0 (/root/sources/pve/proxmox-perl-rs/build/pve-rs)
error[E0433]: failed to resolve: use of undeclared crate or module `proxmox_time`
 --> src/calendar_event.rs:9:26
  |
9 |     struct CalendarEvent(proxmox_time::CalendarEvent);
  |                          ^^^^^^^^^^^^ use of undeclared crate or module `proxmox_time`







More information about the pve-devel mailing list