[pve-devel] applied: [PATCH qemu-server v3] rollback: Only create start task with --start if VM is not running

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Dec 30 15:56:32 CET 2022


Am 21/12/2022 um 17:51 schrieb Stefan Hanreich:
> When rolling back to the snapshot of a VM that includes RAM, the VM
> gets started by the rollback task anyway, so no additional start task
> is needed. Previously, when rolling back with the start parameter and
> the VM snapshot included RAM, a start task was created. That task
> failed because the VM had already been started by the rollback task.
> 
> Additionally documented this behaviour in the description of the start
> parameter
> 
> Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
> ---
> Changes v2 -> v3:
> Use vm_running_locally() instead of check_running()
> Improved description
> 
> Changes v1 -> v2:
> Do not parse config for checking type of snapshot but rather directly check
> whether VM is running or not via check_running()
> 
>  PVE/API2/Qemu.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list