[pve-devel] [PATCH qemu-server 09/10] tests: add virtio-mem tests

[Fiona Ebner]

Am 09.12.22 um 20:27 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  test/cfg2cmd/memory-virtio-hugepages-1G.conf  | 11 ++++++
>  .../memory-virtio-hugepages-1G.conf.cmd       | 35 +++++++++++++++++++
>  test/cfg2cmd/memory-virtio-max.conf           | 10 ++++++
>  test/cfg2cmd/memory-virtio-max.conf.cmd       | 35 +++++++++++++++++++
>  test/cfg2cmd/memory-virtio.conf               | 10 ++++++
>  test/cfg2cmd/memory-virtio.conf.cmd           | 35 +++++++++++++++++++
>  6 files changed, 136 insertions(+)
>  create mode 100644 test/cfg2cmd/memory-virtio-hugepages-1G.conf
>  create mode 100644 test/cfg2cmd/memory-virtio-hugepages-1G.conf.cmd
>  create mode 100644 test/cfg2cmd/memory-virtio-max.conf
>  create mode 100644 test/cfg2cmd/memory-virtio-max.conf.cmd
>  create mode 100644 test/cfg2cmd/memory-virtio.conf
>  create mode 100644 test/cfg2cmd/memory-virtio.conf.cmd
> 
> diff --git a/test/cfg2cmd/memory-virtio-hugepages-1G.conf b/test/cfg2cmd/memory-virtio-hugepages-1G.conf
> new file mode 100644
> index 0000000..616b98e
> --- /dev/null
> +++ b/test/cfg2cmd/memory-virtio-hugepages-1G.conf
> @@ -0,0 +1,11 @@
> +# TEST: virtio-mem with memorymax defined

memorymax not defined. I think get_max_mem() and thus the test then
depends on get_host_phys_address_bits(), i.e. on which host it is run?

> +# QEMU_VERSION: 3.0

It wasn't supported on QEMU 3.0 ;) But it raises the question if we
should introduce version guards for the feature? Not sure what our
current policy is when it comes to actively-opt-in features. Especially
if it's still a technology preview.

> +cores: 2
> +memory: 32768,virtio=1
> +name: simple
> +numa: 1
> +ostype: l26
> +smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465
> +sockets: 2
> +vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8
> +hugepages: 1024
> \ No newline at end of file

(...)

> diff --git a/test/cfg2cmd/memory-virtio.conf b/test/cfg2cmd/memory-virtio.conf
> new file mode 100644
> index 0000000..f88f6f5
> --- /dev/null
> +++ b/test/cfg2cmd/memory-virtio.conf
> @@ -0,0 +1,10 @@
> +# TEST: virtio-mem with memorymax defined

same

> +# QEMU_VERSION: 3.0

same

> +cores: 2
> +memory: 32768,virtio=1
> +name: simple
> +numa: 1
> +ostype: l26
> +smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465
> +sockets: 2
> +vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8
> \ No newline at end of file