[pve-devel] [PATCH manager] report: filter comments in VM/CT configs

Fiona Ebner f.ebner at proxmox.com
Fri Dec 16 13:15:49 CET 2022


Am 15.12.22 um 17:57 schrieb Mira Limbeck:
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 90b7cb1c..7ebe98f7 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -5,16 +5,34 @@ use warnings;
>  
>  use PVE::Tools;
>  
> +my sub file2text {
> +    my ($file, $filter) = @_;
> +    my $text = "\n# cat $file\n";
> +
> +    my $contents = PVE::Tools::file_get_contents($file);
> +    if ($filter) {
> +	foreach my $line (split('\n', $contents)) {
> +	    next if $line =~ m/^\s*#/;
> +	    next if $line =~ m/^cipassword/;
> +
Should we rather mask the value instead of dropping the whole line, so
that we can see that /some/ cipassword is set? Might be more relevant
for future filtered options.





More information about the pve-devel mailing list