[pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Dec 13 13:12:58 CET 2022


Am 21/10/2022 um 11:24 schrieb Dominik Csapak:
> All in all LGTM, one small UX thing that i am not sure if we can improve without
> making it way more complicated:
> 
> We now preselect the current node and leave the restriction out.
> We then restrict when the node changes, but remove the restriction
> again when we select the current node.

IIUC, you mean that the node selector implies that it's restricted to the node that one
has loaded the web-interface with, even if that's then not the case.

As if that's the case then yes, that'd seem like confusing UX.

> 
> Maybe we want to just leave the restriction out when we load
> the panel up, but always restrict when a user sets the node?
> (as in, if i manually select the current node again, restrict
> it?)

And here you propose that we keep the empty value, and thus the "All (No restrictions)"
displayed on edit window creation, and if any node is actually selected by the user then we
always restrict it to that (just to ensure IIUC)?


If IIUC, then yes, while mabye not the best (as its an odd "problem") it might be the
better way.

> 
> not sure if we'd want that or leave it like it is (or something else entirely?)
> @Thomas do you have any thoughts about that?







More information about the pve-devel mailing list