[pve-devel] [PATCH qemu-server] cfg2cmd: factor out ovmf drives printing

Fiona Ebner f.ebner at proxmox.com
Wed Dec 7 10:02:02 CET 2022


Am 06.12.22 um 18:11 schrieb Thomas Lamprecht:
> Am 02/12/2022 um 13:59 schrieb Fiona Ebner:
>> No functional change is intended.
>>
>> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
>> ---
>>
>> Popped out while trying the other approach mentioned in:
>> https://lists.proxmox.com/pipermail/pve-devel/2022-December/055091.html
> 
> looks ok, having it in a separate method opens up a few more "line reduction without
> making it harder to understand" possibilities, e.g., the following diff would drop
> 21 lines, but reorder the var string a bit too - what do you think?
> 

Seems like the tabs got converted to spaces in the diff somewhere along
the way. But other than the few lines that break the 100 char limit, it
looks ok to me :)





More information about the pve-devel mailing list