[pve-devel] [PATCH V4 pve-manager 0/2] add iscsi, lvm, lvmthin & zfs storage on all cluster nodes (fix #2822)

Stefan Hrdlicka s.hrdlicka at proxmox.com
Thu Aug 4 16:46:15 CEST 2022


V1 -> V2:
# pve-storage
* removed because patch is not needed

# pve-manager (1/3)
* remove storage controller from V1
* added custom ComboBox with API URL & setNodeName function
* added scan node selection for iSCSI 
* scan node selection field no longer send to server

## (optional) pve-manager (2/3): cleanup related files
* var to let statement change
* some indentation

## ((very) optional) pve-manager (3/3): cleanup all var statements
* replaces all var with let statements


V2 -> V3:
# pve-manager (1/2)
* fix broken interface (broken in V2 :( )
* improve tooltip
* replace jNodeSelector function with class object
  (PVE.panel.StorageBaseWithNodeSelector)

# other things:
* removed very optional cleanup
* nothing changed for "Base storage" selector. It is still possible to
  select for example an iSCSI device only availabe on one node that
  isn't availabe on the other ones. I wasn't sure if this should be
  changed in this context as well.


V3 -> V4:
# pve-manager (1/2)
* "localhost" is set for "Scan Node"
* if another node is selcted and the "X" (clear) is used, localhost is
  set as the value again
* use lookupReference
* moved used template literals for building path strings

Stefan Hrdlicka (2):
  fix #2822: add lvm, lvmthin & zfs storage for all cluster nodes
  cleanup: "var" to "let", fix some indentation in related files

 www/manager6/storage/Base.js        | 59 +++++++++++++++++++++--
 www/manager6/storage/IScsiEdit.js   | 45 +++++++++++++-----
 www/manager6/storage/LVMEdit.js     | 44 +++++++++++++----
 www/manager6/storage/LvmThinEdit.js | 73 ++++++++++++++++++++---------
 www/manager6/storage/ZFSPoolEdit.js | 52 ++++++++++++++------
 5 files changed, 210 insertions(+), 63 deletions(-)

-- 
2.30.2





More information about the pve-devel mailing list