[pve-devel] [PATCH V3 pve-manager 1/2] fix #2822: add lvm, lvmthin & zfs storage for all cluster nodes

Fiona Ebner f.ebner at proxmox.com
Tue Aug 2 09:29:16 CEST 2022


Am 01.08.22 um 16:30 schrieb Stefan Hrdlicka:
> Hello :)
> 
> On 7/27/22 12:19, Fiona Ebner wrote:
>> Am 19.07.22 um 13:57 schrieb Stefan Hrdlicka:
>>> @@ -42,7 +45,7 @@ Ext.define('PVE.storage.IScsiScan', {
>>>           fields: ['target', 'portal'],
>>>           proxy: {
>>>           type: 'proxmox',
>>> -        url: `/api2/json/nodes/${me.nodename}/scan/iscsi`,
>>> +        url: me.apiBaseUrl + me.nodename + me.apiStoragePath,
>>
>> Style nit: please keep using template string syntax
>> Same for the other ones below
> 
> Exactly this one:
>     url: `/api2/json/nodes/${me.nodename}/scan/iscsi` or do you mean or
> would something like this be ok as well:
>     url: `${me.apiBaseUrl}${me.nodename}${me.apiSuffix}`
> 

The second one please ;)
The change itself is fine, but the template string style is preferred.
In this case, it's not that big of a deal, but when mixing with actual
string literals, it's just nicer to read. And in other rare cases it can
prevent accidental numerical addition.




More information about the pve-devel mailing list