[pve-devel] [PATCH manager 1/1] vzdump: check that notes-template is a single line

Fabian Ebner f.ebner at proxmox.com
Thu Apr 28 10:07:39 CEST 2022


While vzdump itself wouldn't mind about unescaped newlines, the
parameter isn't supposed to contain any, and when used as part of the
job config, it has to be a single line too, so make it consistent.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---

These are follow-ups for the "add protected and notes-template
parameters for vzdump" series.

 PVE/VZDump.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index fcbd87d5..80cbddb5 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -1326,6 +1326,9 @@ sub verify_vzdump_parameters {
 
     $parse_prune_backups_maxfiles->($param, 'CLI parameters');
 
+    raise_param_exc({'notes-template' => "contains a line feed"})
+	if $param->{'notes-template'} && $param->{'notes-template'} =~ m/\n/;
+
     $param->{all} = 1 if (defined($param->{exclude}) && !$param->{pool});
 
     return if !$check_missing;
-- 
2.30.2






More information about the pve-devel mailing list