[pve-devel] applied: [PATCH v2 widget-toolkit 1/3] Buttons: add AltText
Thomas Lamprecht
t.lamprecht at proxmox.com
Wed Apr 27 18:55:40 CEST 2022
On 28.03.22 15:07, Matthias Heiserer wrote:
> The same code is used once in widget toolkit and twice in PVE already,
> so it makes sense to add it as a separate button.
>
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
> changes from v1:
> move into separate class
> rename vars to something a little bit nicer
> move comment above function
> reorder some statements
>
> Note: Because it's now guaranteed that the function is called at render time,
> I think we can leave out the extra logic to test which text is currently set.
>
>
> src/button/AltText.js | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 src/button/AltText.js
>
>
applied with 2/3 squashed in, thanks!
More information about the pve-devel
mailing list