[pve-devel] [PATCH v4 manager 5/7] ui: dc/backup: move note template to own tab and adapt

[Fabian Ebner]

From: Thomas Lamprecht <t.lamprecht at proxmox.com>

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/dc/Backup.js | 49 +++++++++++++++++++++++++++------------
 1 file changed, 34 insertions(+), 15 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 9b129266..df4a70fd 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -229,27 +229,13 @@ Ext.define('PVE.dc.BackupEdit', {
 		{
 		    xtype: 'proxmoxtextfield',
 		    name: 'comment',
-		    fieldLabel: gettext('Comment'),
+		    fieldLabel: gettext('Job Comment'),
 		    deleteEmpty: !me.isCreate,
 		    autoEl: {
 			tag: 'div',
 			'data-qtip': gettext('Description of the job'),
 		    },
 		},
-		{
-		    xtype: 'proxmoxtextfield',
-		    name: 'notes-template',
-		    fieldLabel: gettext('Notes'),
-		    deleteEmpty: !me.isCreate,
-		    value: me.isCreate ? '{{guestname}}' : undefined,
-		    autoEl: {
-			tag: 'div',
-			'data-qtip': Ext.String.format(
-			    gettext('Notes added to the backup. Possible variables are {0}'),
-			    '{{cluster}}, {{guestname}}, {{node}}, {{vmid}}',
-			),
-		    },
-		},
 	    ],
 	    onGetValues: function(values) {
 		if (!values.node) {
@@ -390,6 +376,39 @@ Ext.define('PVE.dc.BackupEdit', {
 			    showPBSHint: false,
 			    fallbackHintHtml: gettext('Without any keep option, the storage\'s configuration or node\'s vzdump.conf is used as fallback'),
 			},
+			{
+			    xtype: 'inputpanel',
+			    title: gettext('Note Template'),
+			    region: 'center',
+			    layout: {
+				type: 'vbox',
+				align: 'stretch',
+			    },
+			    items: [
+				{
+				    xtype: 'textarea',
+				    name: 'notes-template',
+				    fieldLabel: gettext('Backup Notes'),
+                                    height: 100,
+				    maxLength: 512,
+				    deleteEmpty: !me.isCreate,
+				    value: me.isCreate ? '{{guestname}}' : undefined,
+				},
+				{
+				    xtype: 'box',
+				    style: {
+					margin: '8px 0px',
+					'line-height': '1.5em',
+				    },
+				    html: gettext('The notes are added to each backup created by this job.')
+				      + '<br>'
+				      + Ext.String.format(
+					gettext('Possible template variables are: {0}'),
+					['cluster', 'guestname', 'node', 'vmid'].map(v => `<code>{{${v}}}</code>`).join(', '),
+				    ),
+				},
+			    ],
+			},
 		    ],
 		},
 	    ],
-- 
2.30.2