[pve-devel] [PATCH manager 1/3] HDEdit: always show io thread checkbox
Matthias Heiserer
m.heiserer at proxmox.com
Wed Apr 27 14:33:02 CEST 2022
Previously, it was in the advanced section.
In the qemu wizard, bind iothread to the SCSI controller, so that
the unlikely/impossible combination of anything other than SCSI-single
with iothread can't be accidentally selected.
However, in the guest options, iothread and SCSI controller can still
be changed independantly.
Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
---
www/manager6/qemu/HDEdit.js | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c643ee73..9dea9984 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -251,6 +251,17 @@ Ext.define('PVE.qemu.HDInputPanel', {
reference: 'discard',
name: 'discard',
},
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'iothread',
+ fieldLabel: 'IO thread',
+ clearOnDisable: true,
+ bind: {
+ disabled: '{!isVirtIO && !isSCSI}',
+ // only for wizard
+ value: '{current.scsihw === "virtio-scsi-single"}',
+ },
+ },
);
advancedColumn1.push(
@@ -263,15 +274,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
disabled: '{isVirtIO}',
},
},
- {
- xtype: 'proxmoxcheckbox',
- name: 'iothread',
- fieldLabel: 'IO thread',
- clearOnDisable: true,
- bind: {
- disabled: '{!isVirtIO && !isSCSI}',
- },
- },
{
xtype: 'proxmoxcheckbox',
name: 'readOnly', // `ro` in the config, we map in get/set values
--
2.30.2
More information about the pve-devel
mailing list