[pve-devel] applied: [PATCH manager] api2: network: anybridge: re-add regular bridges

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 27 13:56:21 CEST 2022


On 27.04.22 13:36, Fabian Grünbichler wrote:
> commit 052fbb2a4d1bdeb490b2e3b67cd7555e460ebe93 introduced permission
> checks here that caused all regular bridges to be removed from the
> returned list as soon as the SDN package is installed, unless the user
> is root at pam or there exists a VNET with the same ID.
> 
> this is arguably a breaking change, so limit the priv check to actually
> defined VNETs for the time being, and add ALL regular bridges
> uncondtionally like before.
> 
> get_local_vnets already filters by the same prvs, so we need to get the
> full config to find out which IDs are VNETs and which are not.
> 
> once/iff we introduce ACL paths for *all* bridges in the future, we can
> limit accordingly here.
> 
> CC: Alexandre Derumier <aderumier at odiso.com>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
>  PVE/API2/Network.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!





More information about the pve-devel mailing list