[pve-devel] [PATCH proxmox-backup/common/storage/wt v2] improve file-restore timeout behaviour
Dominik Csapak
d.csapak at proxmox.com
Tue Apr 26 12:13:53 CEST 2022
this series improves the behaviour of the file-restore when some mount
operations take longer than the 30 second pveproxy timeout, and improves
the startup speed of the restore vm
we do this by moving the disk init into the background of the daemon
startup, while the hyper server is starting, and by adding a timeout
option to the file-restore binary.
to be able to report the error back to the gui, we return a
'SERVICE_UNAVAILABLE' error in the timeout case, and the gui tries
again (up to 10 times).
backup patches 2,3 could be applied independently, as they even make
sense withouth the rest
pve-storage depends on a new pve-common&file-restore
widget-toolkit makes only sense with the other patches, but is
designed to not change behaviour with the old api
alternatively i could drop the 'json-error' parameter and do it
always, or when timeout it set.
changes from v1:
* rebased on master
* moved the json-error and timeout directly into pve-common (hardcoded)
since there is only one usage of that function
proxmox-backup:
Dominik Csapak (5):
restore-daemon: start disk initialization in parallel to the api
restore-daemon: put blocking code into 'block_in_place'
restore-daemon: avoid auto-mounting zpools
file-restore: factor out 'list_files'
file-restore: add 'timeout' and 'json-error' parameter
proxmox-file-restore/src/main.rs | 206 ++++++++++++------
proxmox-restore-daemon/src/main.rs | 31 ++-
.../src/proxmox_restore_daemon/api.rs | 12 +-
.../src/proxmox_restore_daemon/disk.rs | 20 +-
4 files changed, 166 insertions(+), 103 deletions(-)
pve-common:
Dominik Csapak (1):
PBSClient: file_restore_list: add json-error and timeout parameter
src/PVE/PBSClient.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
pve-storage:
Dominik Csapak (1):
api: FileRestore: decode and return proper error with new file-restore
params
PVE/API2/Storage/FileRestore.pm | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
proxmox-widget-toolkit:
Dominik Csapak (1):
window/FileBrowser: try reload again when getting a 503 error
src/window/FileBrowser.js | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
--
2.30.2
More information about the pve-devel
mailing list