[pve-devel] [PATCH widget-toolkit] fix #3994: Node config options in the GUI

[Thomas Lamprecht]

On 20.04.22 12:09, Daniel Tschlatscher wrote:
> Added a new file for displaying and editing the node config options
> which were not exposed through the GUI yet. Namely those are the
> settings for wakeonlan and startall-on-boot-delay.

Why is this in widget toolkit if it's only PVE specific? (see below)

I'd just add it in pve-manager, no point in adding the headache of splitting a feature
over multiple packages if it cannot be reused anyway.

> Signed-off-by: Daniel Tschlatscher <d.tschlatscher at proxmox.com>
> ---
>  src/Makefile            |  1 +
>  src/node/OptionsView.js | 85 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 86 insertions(+)
>  create mode 100644 src/node/OptionsView.js
> 
> diff --git a/src/Makefile b/src/Makefile
> index dd7729e..0217ae1 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -96,6 +96,7 @@ JSSRC=					\
>  	node/DNSEdit.js			\
>  	node/HostsView.js		\
>  	node/DNSView.js			\
> +	node/OptionsView.js		\
>  	node/Tasks.js			\
>  	node/ServiceView.js		\
>  	node/TimeEdit.js		\
> diff --git a/src/node/OptionsView.js b/src/node/OptionsView.js
> new file mode 100644
> index 0000000..3d1e7bb
> --- /dev/null
> +++ b/src/node/OptionsView.js
> @@ -0,0 +1,85 @@
> +Ext.define('Proxmox.node.OptionsView', {
> +    extend: 'Proxmox.grid.ObjectGrid',
> +    alias: ['widget.proxmoxNodeOptionsView'],
> +
> +    gridRows: [
> +	{
> +	    xtype: 'integer',
> +	    name: 'startall-onboot-delay',

pve specific

> +	    text: gettext('Start on boot delay'),
> +	    minValue: 0,
> +	    maxValue: 300,
> +	    labelWidth: 130,
> +	    deleteEmpty: true,
> +	    renderer: function(value) {
> +		if (value === undefined) {
> +		    return Proxmox.Utils.defaultText;
> +		}
> +
> +		let secString = value === 1 ? gettext('Second') : gettext('Seconds');
> +		return `${value} ${secString}`;
> +	    },
> +	},
> +	{
> +	    xtype: 'text',
> +	    name: 'wakeonlan',

pve specific

> +	    text: gettext('Wake on LAN'),
> +	    vtype: 'MacAddress',
> +	    deleteEmpty: true,
> +	    renderer: function(value) {
> +		if (value === undefined) {
> +		    return Proxmox.Utils.NoneText;
> +		}
> +
> +		return value;
> +	    },
> +	},
> +    ],
> +
> +    initComponent: function() {
> +	let me = this;
> +	let baseUrl = `/nodes/${me.nodename}/config`;

you use nodename before you check that it's set, not that it matters much but it's just not
/that/ nice code-style wise (things tend to get copied and adapted, which such unnecessary
subtleties may cause headache with).

> +
> +	if (!me.nodename) {
> +	    throw "no node name specified";
> +	}
> +
> +	let editBtn = new Ext.Button({
> +	    text: gettext('Edit'),
> +	    disabled: true,
> +	    handler: function() { me.run_editor(); },
> +	});
> +
> +
> +	let setButtonStatus = function() {
> +	    let sm = me.getSelectionModel();
> +	    let rec = sm.getSelection()[0];
> +
> +	    if (!rec) {
> +		editBtn.disable();
> +		return;
> +	    }
> +
> +	    let rowdef = me.rows[rec.data.key];
> +	    editBtn.setDisabled(!rowdef.editor);
> +	};
> +
> +	Ext.apply(me, {
> +	    url: `/api2/json${baseUrl}`,
> +	    tbar: [editBtn],
> +	    editorConfig: {
> +		url: `/api2/extjs/${baseUrl}`,
> +	    },
> +	    listeners: {
> +		itemdblclick: me.run_editor,
> +		selectionchange: setButtonStatus,
> +	    },
> +	});
> +
> +	me.callParent();
> +
> +	me.on('activate', me.rstore.startUpdate);
> +	me.on('deactivate', me.rstore.stopUpdate);
> +	me.on('destroy', me.rstore.stopUpdate);

you could try using a view controller for above, that could theoretically also allow to drop the whole
initComponents. (search the code base for `ViewController`); not a requirement but good to check out
as learning purpose and maybe you like it better.