[pve-devel] [PATCH v6 manager 0/5] ui: lxc/qemu: disk/volume action simplify menu items

Fabian Ebner f.ebner at proxmox.com
Thu Apr 7 14:28:56 CEST 2022


Am 05.04.22 um 14:30 schrieb Aaron Lauterer:
> This series adds the UI to reassign a disk / volume from one guest to another.
> 
> To avoid button clutter, the Move, Reassing and Resize buttons are moved
> into a new submenu called "Disk/Volume Action".
> 
> Patch 1 changes how we store the max number of MPs possible because I
> ran into the issue, that I cannot easily match against the object key if
> it is 'mps' instead of 'mp'.
> 
> Patch 4 to 5 are optional. Patch 4 only changes a double negated option.
> Patch 5 happend in the process of working on an interface for the
> reassign functionality. Since the work of modernizing this componend is
> done, why not use it
> 
> 

Series looks good to me, except for the minor issue in 3/6:

Reviewed-by: Fabian Ebner <f.ebner at proxmox.com>





More information about the pve-devel mailing list