[pve-devel] [PATCH v4 manager 0/4] BackupView as TreePanel

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Apr 7 08:57:09 CEST 2022


On 07.04.22 08:31, Fabian Ebner wrote:
>>> I feel like we should always filter by backup type in the guest view
>>> like is done currently. Otherwise, there is the possibility to try and
>>> restore e.g. an LXC backup over an existing VM. That probably isn't a
>>> common use case, and it just leads to an error.
>>>
>> Yeah that's a must do IMO.
> I might've made it sound worse than it is, by not being specific. By
> default, the type *is* filtered. It's just that the checkbox now is
> "filter VMID+type" vs. previously, "filter VMID" with type filtering
> always active. As turning off that checkbox is a relatively uncommon use
> case to begin with, I didn't consider it a must.

I still do consider it a must. The checkbox is always shown and easily
accessible, I see no reason to label using it as edge-case and showing backup
files that cannot work can only confuse users and just isn't hard to fix.





More information about the pve-devel mailing list