[pve-devel] [PATCH v4 manager 0/4] BackupView as TreePanel

[Thomas Lamprecht]

On 06.04.22 13:26, Fabian Ebner wrote:
> Am 04.04.22 um 15:02 schrieb Matthias Heiserer:
>> Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
>>
>> Matthias Heiserer (4):
>>   ui: Utils: Helpers for backup type and icon
>>   ui: storage: Rewrite backup content view as TreePanel.
>>   ui: delete BackupView and replace it with the new Tree BackupView
>>   ui: content view: remove dead code
>>
>>  www/manager6/Makefile               |   1 -
>>  www/manager6/Utils.js               |  20 +
>>  www/manager6/grid/BackupView.js     | 388 -------------
>>  www/manager6/lxc/Config.js          |   2 +-
>>  www/manager6/qemu/Config.js         |   2 +-
>>  www/manager6/storage/BackupView.js  | 817 +++++++++++++++++++++-------
>>  www/manager6/storage/ContentView.js |  43 +-
>>  7 files changed, 657 insertions(+), 616 deletions(-)
>>  delete mode 100644 www/manager6/grid/BackupView.js
>>
> 
> Great! I've just got one complaint left (and a few nits, see my answer
> to 2/4). Repeating the complaint here:
> 
> I feel like we should always filter by backup type in the guest view
> like is done currently. Otherwise, there is the possibility to try and
> restore e.g. an LXC backup over an existing VM. That probably isn't a
> common use case, and it just leads to an error.
> 

Yeah that's a must do IMO.