[pve-devel] applied: [PATCH manager] fix #3976: api/backup: make schedule/starttime truly optional on update

[Thomas Lamprecht]

On 01.04.22 08:14, Dominik Csapak wrote:
> on create we require either starttime (+dow) or a schedule, but when
> updating an existing job, this is not necessary
> 
> before we changed to schedules, the starttime was not optional either on
> update, but i think there is no reason to require the user to send the
> schedule/startime along every time.
> 
> the gui will send all values every time, so that was never a problem there
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/API2/Backup.pm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
>

applied, thanks!

albeit the "$required" param name made me ask "required what?", but as the
check fn is "private" and small enough I don't think its a real code smell
issue.