[pve-devel] [PATCH v2 storage 2/7] dir plugin: get notes: return undef if notes are not supported

Fabian Ebner f.ebner at proxmox.com
Thu Sep 30 13:42:05 CEST 2021

This avoids showing empty notes in the result of the content/{volid}
API call for volumes that do not even support notes. It's also in
preparation for the proposed get_volume_attribute generalization,
which expects undef to be returned when an attribute is not supported.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>

New in v2.

 PVE/Storage/DirPlugin.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm
index 30ed7ca..0ac9b06 100644
--- a/PVE/Storage/DirPlugin.pm
+++ b/PVE/Storage/DirPlugin.pm
@@ -93,6 +93,9 @@ sub parse_is_mountpoint {
 sub get_volume_notes {
     my ($class, $scfg, $storeid, $volname, $timeout) = @_;
+    my ($vtype) = $class->parse_volname($volname);
+    return if $vtype ne 'backup';
     my $path = $class->filesystem_path($scfg, $volname);
     $path .= $class->SUPER::NOTES_EXT;

More information about the pve-devel mailing list