[pve-devel] [PATCH-SERIES storage/widget-toolkit/manager] disk creation and wiping improvements
Fabian Ebner
f.ebner at proxmox.com
Tue Sep 28 13:39:40 CEST 2021
which also fixes the remaining parts of #2285, i.e. extending
the diskmanage module and creation to support partitions.
The series consists of:
Tighten the checks in the disk creation paths by re-doing them after
forking/locking.
Work around a udev bug[0] leading to outdated device info from lsblk,
by explicitly calling udevadm trigger in the appropriate places.
Add support for partitions for the disk creation paths (both back-end
and UI).
Also change the partition type in the appropriate places as that
information is used when querying disk info.
[0]: https://github.com/systemd/systemd/issues/18525
Ultimately, pve-manager depends on both pve-storage and
proxmox-widget-toolkit, but many things can be applied independently.
pve-storage:
Fabian Ebner (10):
api: disks: create: re-check disk after fork/lock
api: disk: work around udev bug to ensure its database is updated
diskmanage: add change_parttype helper
diskmanage: wipe blockdev: also change partition type
diskmanage: don't set usage for unused partitions
api: disks: initgpt: explicitly abort for partitions
diskmanage: allow partitions for get_udev_info
diskmanage: allow passing partitions to get_disks
partially fix #2285: api: disks: allow partitions for creation paths
api: disks: create: set correct partition type
PVE/API2/Disks.pm | 12 +++++++-
PVE/API2/Disks/Directory.pm | 37 ++++++++++++++++-------
PVE/API2/Disks/LVM.pm | 15 +++++++++-
PVE/API2/Disks/LVMThin.pm | 13 ++++++++
PVE/API2/Disks/ZFS.pm | 36 ++++++++++++++++++++--
PVE/Diskmanage.pm | 60 +++++++++++++++++++++++++++++--------
6 files changed, 145 insertions(+), 28 deletions(-)
proxmox-widget-toolkit:
Fabian Ebner (2):
(multi) disk selector: allow requesting partitions too
disk list: allow wiping individual partitions
src/form/DiskSelector.js | 7 +++++++
src/form/MultiDiskSelector.js | 22 +++++++++++++++++-----
src/panel/DiskList.js | 8 --------
3 files changed, 24 insertions(+), 13 deletions(-)
pve-manager:
Fabian Ebner (9):
api: ceph: create osd: re-check disk requirements after fork/lock
api: check: create osd: use wipe_blockdev from the Diskmanage package
api: ceph: create osd: work around udev bug
api: ceph: create osd: set correct parttype for DB/WAL
partially fix #2285: api: ceph: create osd: allow using partitions
api: ceph: create osd: set correct partition type
partially fix #2285: ui: ceph: allow selecting partitions
ui: zfs create: switch to using widget-toolkit's multiDiskSelector
partially fix #2285: ui: disk create: allow selecting partitions
PVE/API2/Ceph/OSD.pm | 112 +++++++++++++++++++++++++--------
PVE/Ceph/Tools.pm | 23 -------
www/manager6/ceph/OSD.js | 3 +
www/manager6/node/Directory.js | 1 +
www/manager6/node/LVM.js | 1 +
www/manager6/node/LVMThin.js | 1 +
www/manager6/node/ZFS.js | 81 ++----------------------
7 files changed, 96 insertions(+), 126 deletions(-)
--
2.30.2
More information about the pve-devel
mailing list