[pve-devel] applied-series-partially: [PATCH-SERIES v2 manager] ui: some backup job improvements

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 21 15:31:20 CEST 2021


On 21.09.21 13:22, Fabian Ebner wrote:
> The only thing remaining from v1 is adding a cluster-wide storage
> selector for the cluster-wide backup job editor.
> 
> The new approach is to re-use the existing storage selector and add
> a config option to enable cluster-wide selection.
> 
> 
> Changes from v1:
>     * Dropped already applied patches.
>     * Extend existing storage selector to also support a cluster view
>       instead of adding a new storage selector.
> 
> 
> pve-manager:
> 
> Fabian Ebner (4):
>   ui: storage selector: only check for nodename before loading storage
>   ui: storage selector: add new clusterView option
>   ui: cluster backup: only restrict storages to node when it's selected
>   ui: storage selector: use storage type renderer
> 
>  www/manager6/dc/Backup.js            |   4 +-
>  www/manager6/form/StorageSelector.js | 109 +++++++++++++++++++++------
>  2 files changed, 88 insertions(+), 25 deletions(-)
> 



applied all but the last one, I get where you come from but this is just to much
wasted space most of the time IMO, especially in the non-backup job cases, as there
we can never have a PBS and the other storage type names are all quite a bit shorter..

anyhow, thanks for the other stuff!





More information about the pve-devel mailing list