[pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Sep 10 12:03:04 CEST 2021


On September 10, 2021 11:26 am, Dominik Csapak wrote:
> Isn't this technically a breaking api change?
> 
> I.e. if someone relies on the '{data:null}' return for a successfull
> template task start, it would now break?
> 
> Not that i'm opposed to the patch (on the contrary), just wanted
> to clarify

technically yes, in the same way that adding new fields to a return type 
might trip up a very strict client implementation, and we do that all 
the time ;)

the alternative would be to opt-into the new return type via an optional 
parameter, but that just seems ugly (we don't enforce the return schema, 
so we can have an API endpoint return null or the UPID if we want based 
on whatever condition).

IMHO the fallout risk is minimal, the benefit is there, and not 
returning it in the first place was a bug.




More information about the pve-devel mailing list