[pve-devel] applied: [PATCH qemu-server] fix #3608: unbreak removal of scsi controller

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Sep 9 17:53:19 CEST 2021


On 09.09.21 14:40, Fabian Grünbichler wrote:
> the assumption that the index of the controller matches that of the last
> removed drive only holds for virtio-scsi-single controller, which makes
> the old code print a warning when removing the last drive of a
> non-virtio-scsi-single controller except when the indices line up by
> chance.
> 
> we can simply only call a simplified qemu_iothread_del when removing a
> scsi disk of a VM with the virtio-scsi-single controller, and skip the
> call for the other controllers which don't support io-threads anyway.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> alternatively we could keep the old version but conditionally only call
> it for virtioscsi.* and not for scsihw.*, but the now aligned signature
> for adding and removing iothread objects seems like a nice bonus to me
> ;)
> 
>  PVE/QemuServer.pm | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
>

applied, thanks! Thrown in some white space/indentation fixes I noticed in the
surrounding code when checking out this patch more closely.




More information about the pve-devel mailing list