[pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.

Alexandre Derumier aderumier at odiso.com
Fri Sep 3 08:36:00 CEST 2021


This option don't have any impact on device itself.

Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
---
 PVE/QemuServer.pm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index cc73af8..09701e0 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4743,6 +4743,8 @@ sub vmconfig_hotplug_pending {
 	    } elsif ($opt eq 'cpulimit') {
 		my $cpulimit = $conf->{pending}->{$opt} == 0 ? -1 : int($conf->{pending}->{$opt} * 100000);
 		$cgroup->change_cpu_quota($cpulimit, 100000);
+	    } elsif ($opt eq 'agent') {
+		vmconfig_update_agent($conf, $opt, $value);
 	    } else {
 		die "skip\n";  # skip non-hot-pluggable options
 	    }
@@ -4902,6 +4904,23 @@ sub vmconfig_update_net {
     }
 }
 
+sub vmconfig_update_agent {
+    my ($conf, $opt, $value) = @_;
+
+    if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
+
+	my $agent = parse_guest_agent({$opt => $value});
+
+	# skip non hotpluggable value
+	if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
+	    safe_string_ne($agent->{type}, $old_agent->{type})) {
+		    die "skip\n";
+	}
+    }
+    die "skip\n";
+
+}
+
 sub vmconfig_update_disk {
     my ($storecfg, $conf, $hotplug, $vmid, $opt, $value, $arch, $machine_type) = @_;
 
-- 
2.30.2




More information about the pve-devel mailing list