[pve-devel] [PATCH-SERIES manager/proxmox-ve] warn against/prevent using virtual console for major upgrade

[Fabian Ebner]

Could I get some feedback for this?

Am 13.09.21 um 14:04 schrieb Fabian Ebner:
> Quoting from the upgrade notes:
> 
>> Perform the actions via console or ssh; preferably via console to avoid
>> interrupted ssh connections. Do not carry out the upgrade when connected
>> via the virtual console offered by the GUI; as this will get interrupted
>> during the upgrade.
> 
> But some users still seem to miss this, so let's be more direct.
> 
> One part is proxmox-ve patches #1 and #2, just mentioning it up front.
> 
> The other two patches (sent as RFC, as I'm not sure this is the best
> approach), would make it a hard error when a console started via
> API/GUI is detected upon attempting a major upgrade.
> 
> 
> All patches are also intended for stable-6. Note that proxmox-ve does
> not currently have a stable-6 branch, I used
> 286285a9a441ad5b1a3c1869373bfbaadbb70bb4 as a base when testing.
> 
> 
> proxmox-ve depends on pve-manager for the new behavior to take effect,
> but it's not a hard dependency.
> 
> 
> pve-manager:
> 
> Fabian Ebner (1):
>    api: nodes: set environment variable for shells started via the API
> 
>   PVE/API2/Nodes.pm | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> proxmox-ve:
> 
> Fabian Ebner (3):
>    apt hook: avoid long line and fix typo
>    apt hook: mention that console/ssh should be used for major upgrade
>    apt hook: disallow major upgrade via virtual console from API/UI
> 
>   debian/apthook/pve-apt-hook | 15 +++++++++++----
>   1 file changed, 11 insertions(+), 4 deletions(-)
>