[pve-devel] [PATCH-SERIES storage/guest-common/manager] Follow-up for fixing replication/rollback interaction

[Fabian Ebner]

Returning more information about snapshots allows for better decisions
when picking the incremental base snapshot. Namely, to distinguish
between different snapshots with the same name, and to choose a more
recent snapshot in some cases, reducing the send delta. On top of
that, the code in find_common_replication_snapshot becomes simpler.

Mostly as discussed off-list with Fabian G., but instead of just
changing the return type of volume_snapshot_list, it has been replaced
with a new function. I felt like that would allow for a cleaner break
and the old name was not fully accurate anymore.


Applies on top of the original series:
https://lists.proxmox.com/pipermail/pve-devel/2021-August/049699.html


Dependencies/breaks:
1. pve-guest-common (except patch #1) depends on pve-storage patch #1.
2. pve-storage patch #2 breaks old pve-guest-common.
3. pve-guest-common patch #2 build-breaks old pve-manager.
4. pve-manager patch #3 build-depends on pve-guest-common patch #2.


pve-storage:

Fabian Ebner (3):
  plugin: add volume_snapshot_info function
  plugin: remove volume_snapshot_list
  bump APIVER and APIAGE

 ApiChangeLog                 | 16 ++++++++++++++++
 PVE/Storage.pm               | 21 +++++++--------------
 PVE/Storage/Plugin.pm        | 11 ++++++-----
 PVE/Storage/ZFSPlugin.pm     |  6 ------
 PVE/Storage/ZFSPoolPlugin.pm | 23 ++++++++++++++++++-----
 5 files changed, 47 insertions(+), 30 deletions(-)


pve-guest-common:

Fabian Ebner (4):
  replication: refactor finding most recent common replication snapshot
  replication: prepare: return additional information about snapshots
  replication: find common snapshot: use additional information
  config: snapshot delete check: use volume_snapshot_info

 src/PVE/AbstractConfig.pm |  4 +--
 src/PVE/Replication.pm    | 73 ++++++++++++++++++---------------------
 2 files changed, 36 insertions(+), 41 deletions(-)


pve-manager:

Fabian Ebner (3):
  test: replication: avoid implicit return for volume_snapshot
  test: replication: mock volume_snapshot_info
  test: replication: remove mocking for obsolete volume_snapshot_list

 test/ReplicationTestEnv.pm | 40 +++++++++++++++++++++++---------------
 1 file changed, 24 insertions(+), 16 deletions(-)

-- 
2.30.2