[pve-devel] applied: [PATCH qemu-server 1/2] snapshot: fix tpmstate with rbd
t.lamprecht at proxmox.com
Mon Oct 18 09:46:12 CEST 2021
On 14.10.21 11:28, Stefan Reiter wrote:
> QEMU doesn't know about the tpmstate, so 'do_snapshots_with_qemu' should
> never return true in that case. Note that inconsistencies related to
> snapshot timing do not matter much, as the actual TPM data is exported
> together with other device state by QEMU anyway.
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> As reported in the forum: https://forum.proxmox.com/threads/vtpm-support-do-we-have-guide-to-add-the-vtpm-support.56982/post-423381
> PVE/QemuServer.pm | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
applied, thanks! But, ...
> return if $deviceid =~ m/tpmstate0/;
... isn't there a better word boundary we could check for in the match to avoid
(rare but as you used a match vs. equal probably not impossible) false positives?
More information about the pve-devel