[pve-devel] applied: [PATCH qemu-server v3 3/3] fix #3258: block vm start when pci device is already in use

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 15 19:59:45 CEST 2021


On 07.10.21 15:45, Dominik Csapak wrote:
> on vm start, we reserve all pciids that we use, and
> remove the reservation again in vm_stop_cleanup
> 
> first with only a time-based reservation but after the vm is started,
> we reserve again but with the pid.
> 
> for this, we have to move the start_timeout calculation above the
> hostpci handling.
> 
> also moved the pci initialization out of the conf parsing loop
> so that we can reserve all ids before we actually touch any of them
> 
> while touching the lines, fix the indentation
> 
> this way, when a vm starts with a pci device that is already configured
> for a different running vm, will not be started and the user gets
> the error that the device is already in use
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/QemuServer.pm | 50 +++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 42 insertions(+), 8 deletions(-)
> 
>

applied but had to resolve a merge conflict which, thanks!





More information about the pve-devel mailing list