[pve-devel] [PATCH-SERIES v3 storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images

Fabian Ebner f.ebner at proxmox.com
Tue Oct 12 10:25:57 CEST 2021


If a patch and its context doesn't change code-wise, you can add the 
Reviewed-by and Tested-by tags from the previous version.

While testing, I found that the last patch is missing 'glusterfs' in the 
list of storage types. Except for that:

Reviewed-by: Fabian Ebner <f.ebner at proxmox.com>
Tested-by: Fabian Ebner <f.ebner at proxmox.com>

Am 11.10.21 um 14:13 schrieb Lorenz Stechauner:
> changes to v2:
> * cleaned up commit message for pve-storage
> * changed implementation to put the preallocation selector on the column with fewer items
> 
> changes to v1:
> * adjusted preallocation api description
> * moved sub preallocation_cmd_option above `# Storage implementation`
> * updated PreallocationSelector to work with `default`
> * reworked placement of Prealloc.Selector in Base.js
> 
> 
> pve-storage:
> Lorenz Stechauner (1):
>    fix #3580: plugins: make preallocation mode selectable for qcow2 and
>      raw images
> 
>   PVE/Storage/BTRFSPlugin.pm     |  1 +
>   PVE/Storage/CIFSPlugin.pm      |  1 +
>   PVE/Storage/DirPlugin.pm       |  1 +
>   PVE/Storage/GlusterfsPlugin.pm |  4 ++-
>   PVE/Storage/NFSPlugin.pm       |  1 +
>   PVE/Storage/Plugin.pm          | 48 +++++++++++++++++++++++++++++++++-
>   6 files changed, 54 insertions(+), 2 deletions(-)
> 
> 
> pve-manager
> Lorenz Stechauner (2):
>    ui: add PreallocationSelector
>    fix 3850: ui: storage: using PreallocationSelector for file based
>      storage types
> 
>   www/manager6/Makefile                      |  1 +
>   www/manager6/controller/StorageEdit.js     |  6 ++++++
>   www/manager6/form/PreallocationSelector.js | 11 +++++++++++
>   www/manager6/storage/Base.js               | 20 ++++++++++++++++++++
>   www/manager6/storage/NFSEdit.js            |  2 +-
>   5 files changed, 39 insertions(+), 1 deletion(-)
>   create mode 100644 www/manager6/form/PreallocationSelector.js
> 




More information about the pve-devel mailing list