[pve-devel] [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal

Stefan Reiter s.reiter at proxmox.com
Mon Oct 11 14:55:19 CEST 2021


and reorder the panel a bit, as otherwise I found it *very* cluttered.

Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
---
 www/manager6/qemu/SystemEdit.js | 50 +++++++++++++++------------------
 1 file changed, 22 insertions(+), 28 deletions(-)

diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js
index 362365a9..8d178f06 100644
--- a/www/manager6/qemu/SystemEdit.js
+++ b/www/manager6/qemu/SystemEdit.js
@@ -69,28 +69,15 @@ Ext.define('PVE.qemu.SystemInputPanel', {
 	    comboItems: PVE.Utils.kvm_vga_driver_array(),
 	},
 	{
-	    xtype: 'proxmoxcheckbox',
-	    name: 'agent',
-	    uncheckedValue: 0,
-	    defaultValue: 0,
-	    deleteDefaultValue: true,
-	    fieldLabel: gettext('Qemu Agent'),
-	},
-    ],
-
-    column2: [
-	{
-	    xtype: 'pveScsiHwSelector',
-	    name: 'scsihw',
+	    xtype: 'proxmoxKVComboBox',
+	    name: 'machine',
 	    value: '__default__',
-	    bind: {
-		value: '{current.scsihw}',
-	    },
-	    fieldLabel: gettext('SCSI Controller'),
+	    fieldLabel: gettext('Machine'),
+	    comboItems: [
+		['__default__', PVE.Utils.render_qemu_machine('')],
+		['q35', 'q35'],
+	    ],
 	},
-    ],
-
-    advancedColumn1: [
 	{
 	    xtype: 'pveQemuBiosSelector',
 	    name: 'bios',
@@ -126,16 +113,23 @@ Ext.define('PVE.qemu.SystemInputPanel', {
 	},
     ],
 
-    advancedColumn2: [
+    column2: [
 	{
-	    xtype: 'proxmoxKVComboBox',
-	    name: 'machine',
+	    xtype: 'pveScsiHwSelector',
+	    name: 'scsihw',
 	    value: '__default__',
-	    fieldLabel: gettext('Machine'),
-	    comboItems: [
-		['__default__', PVE.Utils.render_qemu_machine('')],
-		['q35', 'q35'],
-	    ],
+	    bind: {
+		value: '{current.scsihw}',
+	    },
+	    fieldLabel: gettext('SCSI Controller'),
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'agent',
+	    uncheckedValue: 0,
+	    defaultValue: 0,
+	    deleteDefaultValue: true,
+	    fieldLabel: gettext('Qemu Agent'),
 	},
 	{
 	    xtype: 'proxmoxcheckbox',
-- 
2.30.2






More information about the pve-devel mailing list