[pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 7 14:55:18 CEST 2021


there are a few ways to implement that and the commit message gives zero reasoning
about the chosen one, I do not really like that...

why not allowing one to enter it as suffix in the host field like we do in PBS for
the remotes.

An extra field is always distracting for newer users as it's yet another choice one can possible make,

On 07.10.21 14:42, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
> ---
>  www/manager6/storage/PBSEdit.js | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
> index fcbc9548..0d7b8033 100644
> --- a/www/manager6/storage/PBSEdit.js
> +++ b/www/manager6/storage/PBSEdit.js
> @@ -465,6 +465,13 @@ Ext.define('PVE.storage.PBSInputPanel', {
>  		fieldLabel: gettext('Server'),
>  		allowBlank: false,
>  	    },
> +	    {
> +		xtype: me.isCreate ? 'numberfield' : 'displayfield',
> +		name: 'port',
> +		value: 8007,
> +		fieldLabel: gettext('Port'),
> +		allowBlank: false,
> +	    },
>  	    {
>  		xtype: me.isCreate ? 'textfield' : 'displayfield',
>  		name: 'username',
> 





More information about the pve-devel mailing list