[pve-devel] applied: [PATCH container 2/2] setup: also set contents of /etc/timezone

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 7 14:34:47 CEST 2021


On 07.10.21 12:48, Fabian Ebner wrote:
> Some distributions like CentOS 8 and Gentoo don't have the file, so
> only update if it already existed.
> 
> A slight change in behavior in set_timezone is that the warning will
> now trigger if /etc/localtime is a link to $tz_path, but $tz_path does
> not exist. Previously, it would return early if the link matched.
> 
> Programs that rely on /etc/timezone within the container will now see
> the configured timezone too. While that is more correct, it's still a
> change that might be unexpected.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/pct-create-command-with-timezone-host-option-fails-to-create-a-container.97538/
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> Does this need to wait until PVE 8.0, because of potential breakage?

nah, we changed setup stuff all the time, not that frequently anymore
because pve-container is quite stable/mature since a while but still
here and then.

If users report issues with the change we can still adapt to that.

> 
>  src/PVE/LXC/Setup.pm      |  1 +
>  src/PVE/LXC/Setup/Base.pm | 16 +++++++++++-----
>  2 files changed, 12 insertions(+), 5 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list