[pve-devel] [PATCH v2 qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.

[Fabian Grünbichler]

On October 5, 2021 11:46 am, Alexandre Derumier wrote:
> This option don't have any impact on device itself.
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/QemuServer.pm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 076ce59..907d522 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4829,6 +4829,8 @@ sub vmconfig_hotplug_pending {
>  	    } elsif ($opt eq 'cpulimit') {
>  		my $cpulimit = $conf->{pending}->{$opt} == 0 ? -1 : int($conf->{pending}->{$opt} * 100000);
>  		$cgroup->change_cpu_quota($cpulimit, 100000);
> +	    } elsif ($opt eq 'agent') {
> +		vmconfig_update_agent($conf, $opt, $value);
>  	    } else {
>  		die "skip\n";  # skip non-hot-pluggable options
>  	    }
> @@ -4988,6 +4990,23 @@ sub vmconfig_update_net {
>      }
>  }
>  
> +sub vmconfig_update_agent {
> +    my ($conf, $opt, $value) = @_;
> +
> +    if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
> +
> +	my $agent = parse_guest_agent({$opt => $value});
> +
> +	# skip non hotpluggable value

shouldn't this be the other way round? check keys which are different, 
and have a list of hotpluggable ones, skip if any others are different?

that way if we add another property to the agent it's fail-safe 
(defaults to not being hotpluggable) until it is added to the explicit 
list.

> +	if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
> +	    safe_string_ne($agent->{type}, $old_agent->{type})) {
> +		    die "skip\n";
> +	}
> +    } else {
> +	die "skip\n";
> +    }
> +}
> +
>  sub vmconfig_update_disk {
>      my ($storecfg, $conf, $hotplug, $vmid, $opt, $value, $arch, $machine_type) = @_;
>  
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
>