[pve-devel] [PATCH qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.

DERUMIER, Alexandre Alexandre.DERUMIER at groupe-cyllene.com
Tue Oct 5 11:48:28 CEST 2021




+sub vmconfig_update_agent {
+    my ($conf, $opt, $value) = @_;
+
+    if ($conf->{$opt} && (my $old_agent = parse_guest_agent($conf))) {
+
+       my $agent = parse_guest_agent({$opt => $value});
+
+       # skip non hotpluggable value
+       if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) ||
+           safe_string_ne($agent->{type}, $old_agent->{type})) {
+                   die "skip\n";
+       }
+    }
+    die "skip\n";

but this method always skips no matter what?


oh, sorry, it should be in an else (agent is disabled)

I just sent a fixed v2



More information about the pve-devel mailing list