[pve-devel] applied: [PATCH manager 1/2] ui: storage: change CIFS to SMB/CIFS

Aaron Lauterer a.lauterer at proxmox.com
Tue Oct 5 08:34:22 CEST 2021



On 10/5/21 07:41, Thomas Lamprecht wrote:
> On 04.10.21 12:25, Aaron Lauterer wrote:
>> This will hopefully help people to find the needed storage as not
>> everyone will be aware of the fact that CIFS is also a name used for it
>> (technically it was only SMB v1).
> 
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>>   www/manager6/Utils.js | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> 
> applied both patches, thanks!
> 
> As they do one thing, i.e., switching "CIFS" to "SMB/CIFS" in the ui it would
> be fine, or rather even better, in one patch. But, as people rather tend to throw
> everything together and squashing is easier than splitting on review take it not
> as direct/big complaint ;-)

Hehehe, yeah, I was thinking exactly about that and then decided to err on the more verbose side ;)
> 




More information about the pve-devel mailing list