[pve-devel] applied: [PATCH v3 manager 3/3] ui: add support for adding TPM devices

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Oct 5 07:34:24 CEST 2021


On 04.10.21 17:29, Stefan Reiter wrote:
> Inspired by HDEfi for efidisks. Extends the DiskStorageSelector to allow
> hiding the format, since tpmstate can only be stored in 'raw' format
> (even on directory storages).
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  www/manager6/Makefile                    |  1 +
>  www/manager6/Utils.js                    |  2 +-
>  www/manager6/form/DiskStorageSelector.js |  5 +-
>  www/manager6/qemu/HDMove.js              |  1 +
>  www/manager6/qemu/HDTPM.js               | 88 ++++++++++++++++++++++++
>  www/manager6/qemu/HardwareView.js        | 25 ++++++-
>  6 files changed, 119 insertions(+), 3 deletions(-)
>  create mode 100644 www/manager6/qemu/HDTPM.js
> 
>

applied, thanks!

But I'm once again remebered that the sepcial disk like efidisk and now tpmstate
are really weird when being removed, as they get marked as unused disk and when
one tries to re-attach them they'll act like they really are a disk.

But, this is nothing new and its the dropping of information is also a nuisance
for "real" disks, if one has properties set like bus, wwn, ... they're all lost
and re-attaching means recreating all of them, if we'd try to save as much as
possible of those things for unused disks too we could allow to prefill that
information on the re-attach dialogue and also differ between normal disks and
special disks like efi or tpm here. but that's for another seires ;)




More information about the pve-devel mailing list