[pve-devel] [PATCH v2 manager] set https_proxy to http_proxy for querying url metadata

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 25 15:14:27 CET 2021


On 25.11.21 15:11, Oguz Bektas wrote:
> On Thu, Nov 25, 2021 at 03:08:24PM +0100, Thomas Lamprecht wrote:
>> On 25.11.21 14:48, Oguz Bektas wrote:
>>> Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
>>
>> where is this tag coming from? Did not see it on the list, only the comment
>> that it wasn't working?
> 
> yes its fixed now... he did review it, and its only a single line, so i
> thought i'll add it before it gets forgotten along the way ;)
> 

yeah no, that's not how it works.

first, one line or hundreds, that does not matter, especially one-liners can be
pretty bad. Secondly, the patch was completely broken, which got mentioned, that's
not akin to a R-b tag at all.. Nothing was there to get forgotten along the way.




More information about the pve-devel mailing list