[pve-devel] [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option

Dominik Csapak d.csapak at proxmox.com
Thu Nov 18 10:50:10 CET 2021


the change from extjs 6.0.1 to 7.0.0 removed 'onDestroy' but brought
us 'doDestroy' for stores

we did not notice since 'onDestroy' was a private method and thus
the changelog did not mention this (doDestroy is a public method meant
exactly for our use case)

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 src/data/DiffStore.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/data/DiffStore.js b/src/data/DiffStore.js
index e4143f5..935bc11 100644
--- a/src/data/DiffStore.js
+++ b/src/data/DiffStore.js
@@ -28,7 +28,7 @@ Ext.define('Proxmox.data.DiffStore', {
     // config is passed instead of an existing rstore instance
     autoDestroyRstore: false,
 
-    onDestroy: function() {
+    doDestroy: function() {
 	let me = this;
 	if (me.autoDestroyRstore) {
 	    if (Ext.isFunction(me.rstore.destroy)) {
-- 
2.30.2






More information about the pve-devel mailing list