[pve-devel] [PATCH v2 manager 2/3] ui: BusTypeSelector: change noVirtIO to withVirtIO
Aaron Lauterer
a.lauterer at proxmox.com
Mon Nov 15 16:02:08 CET 2021
Double negated properties make it harder than necessary to parse
conditions.
Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
www/manager6/form/BusTypeSelector.js | 4 ++--
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/CDEdit.js | 2 +-
www/manager6/qemu/CIDriveEdit.js | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js
index a420e56f..0f040229 100644
--- a/www/manager6/form/BusTypeSelector.js
+++ b/www/manager6/form/BusTypeSelector.js
@@ -2,7 +2,7 @@ Ext.define('PVE.form.BusTypeSelector', {
extend: 'Proxmox.form.KVComboBox',
alias: 'widget.pveBusSelector',
- noVirtIO: false,
+ withVirtIO: true,
withUnused: false,
initComponent: function() {
@@ -10,7 +10,7 @@ Ext.define('PVE.form.BusTypeSelector', {
me.comboItems = [['ide', 'IDE'], ['sata', 'SATA']];
- if (!me.noVirtIO) {
+ if (me.withVirtIO) {
me.comboItems.push(['virtio', 'VirtIO Block']);
}
diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index 798dc4b2..d84c49d6 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -2,7 +2,7 @@ Ext.define('PVE.form.ControllerSelector', {
extend: 'Ext.form.FieldContainer',
alias: 'widget.pveControllerSelector',
- noVirtIO: false,
+ withVirtIO: true,
withUnused: false,
vmconfig: {}, // used to check for existing devices
@@ -73,7 +73,7 @@ Ext.define('PVE.form.ControllerSelector', {
name: 'controller',
itemId: 'controller',
value: PVE.qemu.OSDefaults.generic.busType,
- noVirtIO: me.noVirtIO,
+ withVirtIO: me.withVirtIO,
withUnused: me.withUnused,
allowBlank: false,
flex: 2,
diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index 72c01037..fc7a59cc 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -71,7 +71,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
if (!me.confid) {
me.bussel = Ext.create('PVE.form.ControllerSelector', {
- noVirtIO: true,
+ withVirtIO: false,
});
items.push(me.bussel);
}
diff --git a/www/manager6/qemu/CIDriveEdit.js b/www/manager6/qemu/CIDriveEdit.js
index 754b8353..a9ca8bf1 100644
--- a/www/manager6/qemu/CIDriveEdit.js
+++ b/www/manager6/qemu/CIDriveEdit.js
@@ -36,7 +36,7 @@ Ext.define('PVE.qemu.CIDriveInputPanel', {
me.items = [
{
xtype: 'pveControllerSelector',
- noVirtIO: true,
+ withVirtIO: false,
itemId: 'drive',
fieldLabel: gettext('CloudInit Drive'),
name: 'drive',
--
2.30.2
More information about the pve-devel
mailing list