[pve-devel] [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE

Fabian Ebner f.ebner at proxmox.com
Mon Nov 15 13:37:56 CET 2021


in the same manner as NT_STATUS_ACCESS_DENIED. It can be assumed to be
a configuration error, so avoid showing the generic "storage <storeid>
is not online". Reported in the community forum:
https://forum.proxmox.com/threads/storage-is-not-online-cifs.99201/post-428858

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 PVE/Storage/CIFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index a3f9ebe..d5efa5f 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++ b/PVE/Storage/CIFSPlugin.pm
@@ -280,7 +280,7 @@ sub check_connection {
 
     if (my $err = $@) {
 	die "$out_str\n" if defined($out_str) &&
-	    ($out_str =~ m/NT_STATUS_ACCESS_DENIED/);
+	    ($out_str =~ m/NT_STATUS_(ACCESS_DENIED|LOGON_FAILURE)/);
 	return 0;
     }
 
-- 
2.30.2





More information about the pve-devel mailing list