[pve-devel] [PATCH access-control] tfa: fix http 404 in get_tfa_entry

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Nov 12 10:37:45 CET 2021


this produced warnings in the journal and returned code 500
instead

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
---
 src/PVE/API2/TFA.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/PVE/API2/TFA.pm b/src/PVE/API2/TFA.pm
index 87d7255..657a74c 100644
--- a/src/PVE/API2/TFA.pm
+++ b/src/PVE/API2/TFA.pm
@@ -3,6 +3,8 @@ package PVE::API2::TFA;
 use strict;
 use warnings;
 
+use HTTP::Status qw(:constants);
+
 use PVE::AccessControl;
 use PVE::Cluster qw(cfs_read_file cfs_write_file);
 use PVE::JSONSchema qw(get_standard_option);
@@ -280,7 +282,7 @@ __PACKAGE__->register_method ({
 	my $tfa_cfg = cfs_read_file('priv/tfa.cfg');
 	my $id = $param->{id};
 	my $entry = $tfa_cfg->api_get_tfa_entry($param->{userid}, $id);
-	raise("No such tfa entry '$id'", 404) if !$entry;
+	raise("No such tfa entry '$id'", code => HTTP::Status::HTTP_NOT_FOUND) if !$entry;
 	return $entry;
     }});
 
-- 
2.30.2






More information about the pve-devel mailing list