[pve-devel] applied: [PATCH v2 http-server 1/1] webproxy: handle unflushed write buffer

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 11 17:04:20 CET 2021


On 11.11.21 15:07, Fabian Grünbichler wrote:
> for proxied requests, we usually tear down the proxy connection
> immediately when closing the source connection. this is not the correct
> course of action for bulk one-way data streams that are proxied, where
> the source connection might be closed, but the proxy connection might
> still have data in the write buffer that needs to be written out.
> 
> push_shutdown already handles this case (closing the socket/FH after it
> has been fully drained).
> 
> one example for such a proxied data stream is the 'migrate' data for a
> remote migration, which gets proxied over a websocket connection.
> terminating the proxied connection early makes the target VM crash for
> obvious reasons.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
>  src/PVE/APIServer/AnyEvent.pm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list