[pve-devel] [PATCH manager 4/4] ui: dc/Backup: add comment field and column

Dominik Csapak d.csapak at proxmox.com
Wed Nov 10 15:02:56 CET 2021


and hide the ID column by default

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/dc/Backup.js          | 17 ++++++++++++++++-
 www/manager6/dc/BackupJobDetail.js |  5 +++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 24fa94a6..45ee7022 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -238,6 +238,14 @@ Ext.define('PVE.dc.BackupEdit', {
 	    onlineHelp: 'chapter_vzdump',
 	    column1: column1,
 	    column2: column2,
+	    columnB: [
+		{
+		    xtype: 'proxmoxtextfield',
+		    name: 'comment',
+		    fieldLabel: gettext('Comment'),
+		    deleteEmpty: !me.isCreate,
+		},
+	    ],
 	    onGetValues: function(values) {
 		if (!values.node) {
 		    if (!me.isCreate) {
@@ -717,6 +725,7 @@ Ext.define('PVE.dc.BackupView', {
 		{
 		    header: gettext('ID'),
 		    dataIndex: 'id',
+		    hidden: true,
 		},
 		{
 		    header: gettext('Node'),
@@ -742,8 +751,14 @@ Ext.define('PVE.dc.BackupView', {
 		    dataIndex: 'storage',
 		},
 		{
-		    header: gettext('Selection'),
+		    header: gettext('Comment'),
+		    dataIndex: 'comment',
+		    renderer: Ext.htmlEncode,
 		    flex: 1,
+		},
+		{
+		    header: gettext('Selection'),
+		    flex: 2,
 		    sortable: false,
 		    dataIndex: 'vmid',
 		    renderer: PVE.Utils.render_backup_selection,
diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js
index 19b3b1a3..8300a7d2 100644
--- a/www/manager6/dc/BackupJobDetail.js
+++ b/www/manager6/dc/BackupJobDetail.js
@@ -246,6 +246,11 @@ Ext.define('PVE.dc.BackupInfo', {
     ],
 
     columnB: [
+	{
+	    xtype: 'displayfield',
+	    name: 'comment',
+	    fieldLabel: gettext('Comment'),
+	},
 	{
 	    xtype: 'label',
 	    name: 'pruneLabel',
-- 
2.30.2





More information about the pve-devel mailing list