[pve-devel] applied-series: [PATCH-SERIES v3] fix #3111: fix interaction of snapshot operations with replication

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Nov 9 17:49:23 CET 2021


On August 12, 2021 1:00 pm, Fabian Ebner wrote:
> For more context, see also:
> https://lists.proxmox.com/pipermail/pve-devel/2021-August/049694.html
> 
> Changes from v2:
>     * Many new patches, as the approach is different:
>       For one, only replication snapshots that are blocking rollback
>       are removed. Second, consider more snapshot candidates when
>       probing for an incremental replication base. Last, instead of
>       directly running replication after rollback, prevent snapshot
>       deletion if it might be the current incremental replication
>       base.
> 
> Many thanks to Fabian G. for discussing those ideas with me!
> 
> All patches are new in v3, except guest-common patch #1, which
> hasn't changed much, and would fix some issues already by itself.
> 
> I think nothing requires an explicit dependency bump, but some things,
> like "remove only the real blockers", will only start working when all
> the pieces are in place.
> 
> 
> storage:
> 
> Fabian Ebner (3):
>   zfspool: add zfs_get_sorted_snapshot_list helper
>   zfspool: add blockers parameter to volume_snapshot_is_possible
>   test: zfspool: extend some rollback is possible tests with new
>     blockers parameter
> 
>  PVE/Storage.pm                 |  4 +--
>  PVE/Storage/BTRFSPlugin.pm     |  2 +-
>  PVE/Storage/Plugin.pm          |  5 ++-
>  PVE/Storage/ZFSPoolPlugin.pm   | 65 +++++++++++++++-------------------
>  test/run_test_zfspoolplugin.pl | 65 +++++++++++++++++++++++++---------
>  5 files changed, 85 insertions(+), 56 deletions(-)
> 
> 
> container:
> 
> Fabian Ebner (1):
>   config: rollback is possible: add blockers parameter
> 
>  src/PVE/LXC/Config.pm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> 
> qemu-server:
> 
> Fabian Ebner (1):
>   config: rollback is possible: add blockers parameter
> 
>  PVE/QemuConfig.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> guest-common:
> 
> Fabian Ebner (7):
>   partially fix #3111: snapshot rollback: improve removing replication
>     snapshots
>   config: rollback: factor out helper for removing replication snapshots
>   partially fix #3111: further improve removing replication snapshots
>   replication: remove unused variable and style fixes
>   replication: pass guest config to find_common_replication_snapshot
>   partially fix #3111: replication: be less picky when selecting
>     incremental base
>   fix #3111 config: snapshot delete: check if replication still needs it
> 
>  src/PVE/AbstractConfig.pm    | 120 +++++++++++++++++++++++++++++++----
>  src/PVE/Replication.pm       |  66 ++++++++++++++++----
>  src/PVE/ReplicationConfig.pm |  14 +++++
>  3 files changed, 177 insertions(+), 23 deletions(-)
> 
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 




More information about the pve-devel mailing list