[pve-devel] [PATCH lxc 2/2] include common.conf in openwrt configuration

[Thomas Lamprecht]

On 08.11.21 14:44, Oguz Bektas wrote:
> necessary for the container to start, otherwise we get stuck in creating
> /dev directory.

why though and what from common settings actually helps would be good to
clarify in such patches..

FWIW, the conf seems very outdated, e.g., lxc tty dirs do not matter much
nowadays IIRC, I'd rather revise/update them a bit more in-depth *after*
the next releases.

> 
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>  config/openwrt.common.conf.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/config/openwrt.common.conf.in b/config/openwrt.common.conf.in
> index 73db6f6..aa2e332 100644
> --- a/config/openwrt.common.conf.in
> +++ b/config/openwrt.common.conf.in
> @@ -1,3 +1,6 @@
> +# This derives from the global common config.
> +lxc.include = @LXCTEMPLATECONFIG@/common.conf
> +
>  # Default console settings
>  lxc.tty.dir = lxc
>  lxc.tty.max = 4
>