[pve-devel] applied: [PATCH manager v2] ui: dc/Cluster: show errors on 'join' info in the view

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Nov 7 21:04:37 CET 2021


On 29.10.21 11:14, Dominik Csapak wrote:
> so instead of getting the 'standalone node' message, the grid
> is masked with the actual api error
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * only show error if it does not match the 'standalone' error
> 
> not sure if matching the *exact* error message is very robust, but AFAICS,
> this did not change for a while now, and even if we'd change it, it
> would be very apparent, as we could not create a cluster in the gui
> anymore.
> 
>  www/manager6/dc/Cluster.js | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
>

applied, thanks! I made some changes in pve-cluster to return a special error case
for this situation to match on, dropping the error now would be rather a breaking
change (our UI would break too..), else I'd have gone for that.





More information about the pve-devel mailing list