[pve-devel] [PATCH-SERIES v3 storage/manager] factoring out RE for backup extension

Dominik Csapak d.csapak at proxmox.com
Thu Nov 4 15:40:11 CET 2021


Series LGTM, looked closely at the regexes,
and they match (semantically), tested around a bit
and all seemed to work.

one super small nit (not a blocker IMHO)

the format/extension/compression handling in 2/2
could maybe use a comment what we do there
(though maybe it's just me who's confused ^^)

On 10/22/21 14:23, Lorenz Stechauner wrote:
> changes to v2:
> * rebased to current master
> * kept old $vztmpl_extension_re to not break pve-manager and added
>      # FIXME [...]
> 
> changes to v1:
> * also renamed iso/vztmpl REs
> * new naming schema: $<X>_EXT_RE_<# of capture groups>
>      for example: $BACKUP_EXT_RE_2
> 
> pve-storage
> Lorenz Stechauner (2):
>    storage: rename REs for iso and vztmpl extensions
>    storage/plugin: factoring out regex for backup extension re
> 
>   PVE/API2/Storage/Status.pm |  8 ++++----
>   PVE/Storage.pm             | 26 +++++++++++++++++---------
>   PVE/Storage/Plugin.pm      | 12 ++++++------
>   3 files changed, 27 insertions(+), 19 deletions(-)
> 
> 
> pve-manager:
> Lorenz Stechauner (1):
>    api: aplinfo: rename REs for iso and vztmpl extensions
> 
>   PVE/APLInfo.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 





More information about the pve-devel mailing list