[pve-devel] applied: [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal

Dominik Csapak d.csapak at proxmox.com
Wed Nov 3 14:02:54 CET 2021


On 10/21/21 13:51, Thomas Lamprecht wrote:
> On 11.10.21 14:55, Stefan Reiter wrote:
>> and reorder the panel a bit, as otherwise I found it *very* cluttered.
>>
>> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
>> ---
>>   www/manager6/qemu/SystemEdit.js | 50 +++++++++++++++------------------
>>   1 file changed, 22 insertions(+), 28 deletions(-)
>>
>>
> 
> applied, thanks!
> 
> But I still find that the visual separation of the hr + space of the advanced section
> provided some UX improvement, felt less crowded that way.
> 
> Maybe we can place that in a box+<legend>Firmware</legend>

could work, would have to test

> thingy or at least have a
> Label-only element with "Firmware" in columnt 1 and an empty element in column 2 to
> somewhat replicate that visual grouping?
> 

we do it like that already for the sync edit options in the realmedit,
so maybe we should stay consistent here and use the same style?

if you want, i can send a patch for this





More information about the pve-devel mailing list